Skip to content

[4.x] Sort super attributes correctly #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

[4.x] Sort super attributes correctly #920

merged 2 commits into from
Jul 10, 2025

Conversation

Jade-GG
Copy link
Collaborator

@Jade-GG Jade-GG commented Jul 10, 2025

This fixes two issues:

  • Super attributes didn't get sorted at all in product listings, causing them to always be sorted by value.
  • Super attributes got sorted by sort_order, however when there are duplicate sort_order values the tiebreaker should be alphabetical based on label.

I've also lightly cleaned up the getOptions code here.

@royduin royduin merged commit 323e032 into master Jul 10, 2025
26 checks passed
@royduin royduin deleted the feature/sort-options-correctly branch July 10, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indykoning indykoning indykoning approved these changes

@royduin royduin Awaiting requested review from royduin royduin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jade-GG @indykoning @royduin