-
Notifications
You must be signed in to change notification settings - Fork 99
Test rapids-dask-dependency UCX protocol selection #1520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
EXITCODE=0 | ||
# shellcheck disable=SC2317 | ||
set_exit_code() { | ||
EXITCODE=$? | ||
rapids-logger "Test failed with error ${EXITCODE}" | ||
} | ||
trap set_exit_code ERR | ||
set +e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Along with lines 47-48, this reproduces the same error handling mechanism as that of ci/test_python.sh
.
@@ -0,0 +1,160 @@ | |||
# SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION & AFFILIATES. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was intended for rapids-dask-dependency but was added here instead because there are no GPU build/test jobs in the rapids-dask-dependency repository. Adding it there would require too much effort for just a temporary test, just testing it here is then preferable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving dask-cuda
Thanks Bradley and Lawrence! |
/merge |
Add a test for rapids-dask-dependency UCX protocol selection based on installed packages. The test was initially intended for rapids-dask-dependency but since there are no GPU tests in there it was instead moved here. This a temporary test that will be removed in the scope of #1517 .