Skip to content

Test rapids-dask-dependency UCX protocol selection #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 9, 2025

Conversation

pentschev
Copy link
Member

@pentschev pentschev commented Jul 8, 2025

Add a test for rapids-dask-dependency UCX protocol selection based on installed packages. The test was initially intended for rapids-dask-dependency but since there are no GPU tests in there it was instead moved here. This a temporary test that will be removed in the scope of #1517 .

@pentschev pentschev self-assigned this Jul 8, 2025
@pentschev pentschev added 2 - In Progress Currently a work in progress feature request New feature or request non-breaking Non-breaking change labels Jul 8, 2025
Copy link

copy-pr-bot bot commented Jul 8, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added python python code needed ci labels Jul 8, 2025
@pentschev
Copy link
Member Author

/ok to test

@pentschev
Copy link
Member Author

/ok to test

@pentschev
Copy link
Member Author

/ok to test

@pentschev
Copy link
Member Author

/ok to test

@pentschev pentschev marked this pull request as ready for review July 9, 2025 08:28
@pentschev pentschev requested review from a team as code owners July 9, 2025 08:28
@pentschev pentschev requested a review from KyleFromNVIDIA July 9, 2025 08:28
@pentschev pentschev added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jul 9, 2025
Comment on lines +21 to +28
EXITCODE=0
# shellcheck disable=SC2317
set_exit_code() {
EXITCODE=$?
rapids-logger "Test failed with error ${EXITCODE}"
}
trap set_exit_code ERR
set +e
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with lines 47-48, this reproduces the same error handling mechanism as that of ci/test_python.sh.

@@ -0,0 +1,160 @@
# SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION & AFFILIATES.
Copy link
Member Author

@pentschev pentschev Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was intended for rapids-dask-dependency but was added here instead because there are no GPU build/test jobs in the rapids-dask-dependency repository. Adding it there would require too much effort for just a temporary test, just testing it here is then preferable.

Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving dask-cuda

@pentschev
Copy link
Member Author

Thanks Bradley and Lawrence!

@pentschev
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 7d9e28a into rapidsai:branch-25.08 Jul 9, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team ci feature request New feature or request non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants