Test rapids-dask-dependency UCX protocol selection #1520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
added
2 - In Progress
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
pentschev
added
3 - Ready for Review
pentschev
commented
Jul 9, 2025
Comment on lines
+21
to
+28
| EXITCODE=0 | ||
| # shellcheck disable=SC2317 | ||
| set_exit_code() { | ||
| EXITCODE=$? | ||
| rapids-logger "Test failed with error ${EXITCODE}" | ||
| } | ||
| trap set_exit_code ERR | ||
| set +e |
There was a problem hiding this comment.
Along with lines 47-48, this reproduces the same error handling mechanism as that of ci/test_python.sh.
pentschev
commented
Jul 9, 2025
| @@ -0,0 +1,160 @@ | |||
| # SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION & AFFILIATES. | |||
There was a problem hiding this comment.
This test was intended for rapids-dask-dependency but was added here instead because there are no GPU build/test jobs in the rapids-dask-dependency repository. Adding it there would require too much effort for just a temporary test, just testing it here is then preferable.
bdice
approved these changes
Jul 9, 2025
|
Thanks Bradley and Lawrence! |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for rapids-dask-dependency UCX protocol selection based on installed packages. The test was initially intended for rapids-dask-dependency but since there are no GPU tests in there it was instead moved here. This a temporary test that will be removed in the scope of #1517 .