Skip to content

RDKTV-37015: platfromSupport is missing from dimmingMode capabilities #6286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sprint/25Q2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions AVOutput/AVOutputTV.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2016,6 +2016,10 @@ namespace Plugin {
returnResponse(false);
}

if (isPlatformSupport("DimmingMode") != 0) {
returnResponse(false);
}

if (getParamIndex("DimmingMode",inputInfo,indexInfo) == -1) {
LOGERR("%s: getParamIndex failed to get \n", __FUNCTION__);
returnResponse(false);
Expand Down Expand Up @@ -2072,6 +2076,10 @@ namespace Plugin {
returnResponse(false);
}

if (isPlatformSupport("DimmingMode") != 0) {
returnResponse(false);
}

if( !isCapablityCheckPassed( "DimmingMode" , inputInfo )) {
LOGERR("%s: CapablityCheck failed for DimmingMode\n", __FUNCTION__);
returnResponse(false);
Expand Down Expand Up @@ -2118,6 +2126,10 @@ namespace Plugin {
returnResponse(false);
}

if (isPlatformSupport("DimmingMode") != 0) {
returnResponse(false);
}

int retval= updateAVoutputTVParam("reset","DimmingMode", inputInfo,PQ_PARAM_DIMMINGMODE,dMode);

if(retval != 0 ) {
Expand Down Expand Up @@ -2171,6 +2183,8 @@ namespace Plugin {
returnResponse(false);
}
else {
response["platformSupport"] = (info.isPlatformSupportVector[0].compare("true") == 0) ? true : false;

for (index = 0; index < info.rangeVector.size(); index++) {
supportedDimmingModeArray.Add(info.rangeVector[index]);
}
Expand Down
2 changes: 1 addition & 1 deletion AVOutput/AVOutputTVHelper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2302,7 +2302,7 @@ namespace Plugin {

}

if ((param == "DolbyVisionMode") || (param == "Backlight") || (param == "CMS") || (param == "CustomWhiteBalance") || (param == "HDRMode") || (param == "BacklightControl")) {
if ((param == "DolbyVisionMode") || (param == "Backlight") || (param == "CMS") || (param == "CustomWhiteBalance") || (param == "HDRMode") || (param == "BacklightControl") || (param == "DimmingMode")) {
configString = param + ".platformsupport";
info.isPlatformSupport = inFile.Get<std::string>(configString);
printf(" platformsupport : %s\n",info.isPlatformSupport.c_str() );
Expand Down
Loading