Advanced flag removal #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag’s purpose is now forcing font-size normalization in case zoom is not supported by the rendering engine
Remove advanced Settings and replace with fontSizeNormalize
Looks like the github action did not catch that…
That should be up to implementers, and not an opinionated choice.
+ Fixing text-align filter on paragraphs
Sloppy Copy & Paste
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #168 by removing the advanced setting flag from user settings submodules selectors.
It is replaced with a flag for forcing fontSize normalization if needed (engine does not support
zoomand book’s font-sizing is styled using absolute units).Keeping as a PR for a couple of days so that consumers can anticipate the change on develop given it impacts implementations significantly – settings applied if they are set, despite the advanced settings flag being absent.