feat: add option to disable horizontal swiping when settings.scroll is true #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecdhansen
changed the title
mickael-menu
force-pushed
the
feat/disable-page-turns-while-scrolling
branch
from
393ce32 to
f2503b8
Compare
mickael-menu
force-pushed
the
feat/disable-page-turns-while-scrolling
branch
from
f2503b8 to
a151710
Compare
mickael-menu
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Thank you @alecdhansen! I just fixed an issue where isScrollEnable was not updated after applying new settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows chapter/resource changing in vertical scroll mode to be prevented when swiping horizontally.
@mickael-menu I originally referenced this feature request here: #521