Skip to content

DOC-4756 sorted set examples with join() #3184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

DOC-4756 sorted set examples with join() #3184

merged 1 commit into from
May 14, 2025

Conversation

andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Feb 18, 2025 •
edited by jira bot
Loading

Make sure that:

  • You have read the contribution guidelines.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

DOC-4756

PR redone to include latest CI updates and to use join() to guarantee running order of CompletableFuture objects.

@andy-stark-redis andy-stark-redis marked this pull request as ready for review February 18, 2025 13:29
tishun
tishun approved these changes May 14, 2025
View reviewed changes
Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tishun tishun added this to the Async milestone May 14, 2025
@tishun tishun merged commit e4b34ed into redis:main May 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tishun tishun tishun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Async
Development

Successfully merging this pull request may close these issues.
2 participants
@andy-stark-redis @tishun