Optimize string concatenation in NodeSelectionInvocationHandler.getNodeDescription() #3262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace String.join with Collectors.joining to avoid intermediate collection creation, improving performance by eliminating the unnecessary List creation step.
Make sure that:
mvn formatter:format
target. Don't submit any formatting related changes.This optimization changes the
getNodeDescription()
method to use the more efficient Stream collector pattern, which directly collects stream elements into a joined string rather than first collecting to an intermediate list. While the functional outcome remains identical, this approach avoids the unnecessary memory allocation of the temporary list collection, resulting in improved performance especially in high-throughput scenarios.The existing test suite confirms that the behavior remains consistent with the previous implementation.
Related Issue
Closes #3261