Skip to content

Revert CI to ubuntu-latest #3273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 25, 2025
Merged

Conversation

tishun
Copy link
Collaborator

@tishun tishun commented Apr 25, 2025

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@tishun tishun requested review from Copilot and ggivo April 25, 2025 11:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request reverts the CI configuration back to ubuntu-latest and temporarily disables a failing test for the Sentinel ACL integration.

  • Reverts the CI runner from ubuntu-24.04 to ubuntu-latest
  • Disables the Sentinel ACL integration test to prevent failures on the latest Linux versions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/test/java/io/lettuce/core/sentinel/SentinelAclIntegrationTests.java Disables failing integration test with a note on Linux compatibility issues
.github/workflows/integration.yml Changes CI runner back to ubuntu-latest
Comments suppressed due to low confidence (1)

src/test/java/io/lettuce/core/sentinel/SentinelAclIntegrationTests.java:32

  • Consider adding a reference (e.g., a ticket ID or a TODO comment) alongside the @disabled annotation to track the resolution of the Linux compatibility issue.
@Disabled("Failing with latest versions of Linux")

@tishun tishun merged commit 8ae293f into redis:main Apr 25, 2025
7 checks passed
@tishun tishun deleted the topic/tishun/fixing-the-ci branch April 25, 2025 12:03
@tishun tishun requested a review from kiryazovi-redis April 25, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant