Feature/backend options #36
Conversation
| if (!$this->drush('fra', array(), array('quiet' => TRUE, 'no' => TRUE))) { | ||
| return FALSE; | ||
| if (!$this->drush('fra', array(), array('quiet' => TRUE, 'no' => TRUE), FALSE)) { | ||
| return drush_set_error(dt("The drush command 'fra' could not be found.")); |
There was a problem hiding this comment.
Not too fond of this message. As I see it, drush fra might fail horrible for many reasons apart from not finding the command, and telling the user that the command is missing might cause a lot of confusion.
Could we capture the output somehow, and just discard it on error? Then we'd be able ta output it in case of error.
|
Agreed, good catch.
Edit: Nevermind, It does work just not through drush_invoke_process(). |
|
Do we need to explicitly return FALSE here since drush_deployotron_run_validate does? |
|
It doesn't need to return false as null is taken as false, but I like to be explicit of the intention. And I'd preface the error log with something like 'Running "drush fra" failed, output:'. The command could fail without any output, in which case it would be confusing. Anyway, we should try to get this into https://github.com/reload/deployotron/tree/generic-commands |
|
I think #38 will work for me. I'm going to test it out and close this PR. |
The 'fra' validatation function added in #34 prints unnecessary messages before a deployment is run, ex. 'Current state matches defaults, aborting.'
The only way to prevent those messages from printing, to my knowledge, is to specify $backend_options as FALSE in drush_invoke_process. This PR makes the $backend_options argument optional in the drush method but defaults it to TRUE for backwards compatibility.