@remotion/renderer
: Improved render time estimates
#5463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
renderEstimatedTime
calculation inrender-media.ts
was inaccurate because it used all frame timings to calculate the average render time, causing the first few slow frames to skew the estimation for the entire render.Problem
The current algorithm:
totalTimeSpentOnFrames
totalTimeSpentOnFrames / renderedFrames
This approach is problematic because:
Solution
Modified the algorithm to track only the most recent 50 frame timings:
Benefits
totalTimeSpentOnFrames
preserved)Changes
MAX_RECENT_FRAME_TIMINGS = 50
constantrecentFrameTimings: number[]
array to track recent frame render timesFixes #5462.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.