Skip to content

fix: weasel will open new browser window if new version got. #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

fxliang
Copy link
Contributor

@fxliang fxliang commented May 26, 2025

chore: make update_weasel_appcast.py working with lower version of python, python 3.10 tested

by this pull request, the release note links will end with index.html, which might let it to be shown inside winsparkle dialog not a new browser window.

image

chore: make update_weasel_appcast.py working with lower version of python, python 3.10 tested
@fxliang fxliang requested a review from lotem May 26, 2025 03:32
@lotem
Copy link
Member

lotem commented May 26, 2025

Is index.html necessary?

@fxliang
Copy link
Contributor Author

fxliang commented May 26, 2025

Is index.html necessary?

a new browser window will be open.

update:
it still open a new browser window... not same as test locally.

@fxliang fxliang merged commit 4374cde into rime:master May 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants