Deal with bad offset for identifier #7793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Advance can advance more than one position. It will skip newlines. As such, we need to get the correct offset here.
bhansconnect
force-pushed
the
bhansconnect/push-ltlytlqrmnmx
branch
from
ae12ca5 to
4f9fc42
Compare
gamebox
reviewed
May 17, 2025
| (malformed_header (1:1-1:2) "missing_header") | ||
| (type_anno (1:3-2:3) | ||
| "b" | ||
| (mod_ty "S" ""))) |
There was a problem hiding this comment.
Doesn't this still seem wrong? Now the type identifier doesn't come through in the SExpr. Or is that a SExpr serialization problem?
There was a problem hiding this comment.
Oh, good catch. Let met test more
There was a problem hiding this comment.
Should be all good now. Changed how we track the tokens.
There was a problem hiding this comment.
Ok, this looks much better here, but I definitely want to fix the way that we intern the strings for Dot* tokens so that the dot is not interned.
gamebox
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advance can advance more than one position.
It will skip newlines.
As such, we need to get the correct offset here.