Basic canonicalize_expr of idents with tests #7806
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamebox
requested review from
smores56 and
lukewilliamboswell
and removed request for
lukewilliamboswell
lukewilliamboswell
previously approved these changes
May 23, 2025
rtfeldman
reviewed
May 24, 2025
| if (parse_ir.tokens.resolveIdentifier(e.token)) |ident| { | ||
| switch (scope.levels.lookup(.ident, ident)) { | ||
| .InScope => { | ||
| return ir.exprs.append(ir.env.gpa, .{ .@"var" = .{ |
There was a problem hiding this comment.
I'm not sure if this was the original intention, but I assumed "var" was referring to the new var keyword for reassignable defs.
Personally I like the name lookup for this because it's an expression that's looking up something by name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just me getting this started and sharing things so that I can make sure I understand what we are trying to accomplish correct.