Skip to content

Update html snapshots #7940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2025
Merged

Conversation

joshuawarner32
Copy link
Collaborator

  • Implement ranges for canonicalize and types sections
  • Use the same highlighting system across everything (TOKENS, PARSE, CANONICALIZE, TYPES)
  • Use local storage to persist a default of what section(s) the user has selected in each pane
  • Switch to 2-space indent for html sexpr output, because omg 8-space tabs in the browser make this go off the screen real fast

* Implement ranges for canonicalize and types sections
* Use the same highlighting system across everything (TOKENS, PARSE, CANONICALIZE, TYPES)
* Use local storage to persist a default of what section(s) the user has selected in each pane
* Switch to 2-space indent for html sexpr output, because omg 8-space tabs in the browser make this go off the screen real fast

// Get the type variable for this definition
// Each definition has a type_var at its node index which represents the type of the definition
const def_var = try ir.idxToTypeVar(&ir.env.types, def_idx);
const def_var = ir.idxToTypeVar(&ir.env.types, def_idx) catch |err| exitOnOom(err);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have been slowly moving back to using try instead of exitOnOom everywhere.

Comment on lines +1019 to +1035
/// Append region information to an S-expression node for a given index in the Canonical IR.
pub fn appendRegionInfoToSexprNode(ir: *const CIR, node: *SExpr, idx: anytype) void {
const region = ir.store.getNodeRegion(@enumFromInt(@intFromEnum(idx)));
ir.appendRegionInfoToSexprNodeFromRegion(node, region);
}

/// Append region information to an S-expression node from a specific region.
pub fn appendRegionInfoToSexprNodeFromRegion(ir: *const CIR, node: *SExpr, region: Region) void {
const info = ir.calcRegionInfo(region);
node.appendByteRange(
ir.env.gpa,
info,
region.start.offset,
region.end.offset,
);
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are long names... much descriptive. 😄

@lukewilliamboswell lukewilliamboswell merged commit 868cd1b into roc-lang:main Jul 5, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants