Update html snapshots #7940
Merged
Update html snapshots #7940
+201
−226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
joshuawarner32
commented
Jul 4, 2025
joshuawarner32
commented
- Implement ranges for canonicalize and types sections
- Use the same highlighting system across everything (TOKENS, PARSE, CANONICALIZE, TYPES)
- Use local storage to persist a default of what section(s) the user has selected in each pane
- Switch to 2-space indent for html sexpr output, because omg 8-space tabs in the browser make this go off the screen real fast
* Implement ranges for canonicalize and types sections * Use the same highlighting system across everything (TOKENS, PARSE, CANONICALIZE, TYPES) * Use local storage to persist a default of what section(s) the user has selected in each pane * Switch to 2-space indent for html sexpr output, because omg 8-space tabs in the browser make this go off the screen real fast
|
|
||
| // Get the type variable for this definition | ||
| // Each definition has a type_var at its node index which represents the type of the definition | ||
| const def_var = try ir.idxToTypeVar(&ir.env.types, def_idx); | ||
| const def_var = ir.idxToTypeVar(&ir.env.types, def_idx) catch |err| exitOnOom(err); | ||
|
|
There was a problem hiding this comment.
We have been slowly moving back to using try instead of exitOnOom everywhere.
Comment on lines
+1019
to
+1035
| /// Append region information to an S-expression node for a given index in the Canonical IR. | ||
| pub fn appendRegionInfoToSexprNode(ir: *const CIR, node: *SExpr, idx: anytype) void { | ||
| const region = ir.store.getNodeRegion(@enumFromInt(@intFromEnum(idx))); | ||
| ir.appendRegionInfoToSexprNodeFromRegion(node, region); | ||
| } | ||
|
|
||
| /// Append region information to an S-expression node from a specific region. | ||
| pub fn appendRegionInfoToSexprNodeFromRegion(ir: *const CIR, node: *SExpr, region: Region) void { | ||
| const info = ir.calcRegionInfo(region); | ||
| node.appendByteRange( | ||
| ir.env.gpa, | ||
| info, | ||
| region.start.offset, | ||
| region.end.offset, | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
These are long names... much descriptive. 😄
lukewilliamboswell
approved these changes
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.