Skip to content

Implement module caching #7979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 9, 2025
Merged

Implement module caching #7979

merged 9 commits into from
Jul 9, 2025

Conversation

lukewilliamboswell
Copy link
Collaborator

No description provided.

@lukewilliamboswell lukewilliamboswell marked this pull request as ready for review July 9, 2025 09:14
@joshuawarner32
Copy link
Collaborator

Looks like the valgrind issues are all in hashing, and I suspect the issue is either:

  • There's some part of the buffer you haven't filled in and you're trying to hash that (unlikely assuming no silly mistakes)
  • One or more of the structs you've copied in have some (uninitialized!) padding bytes, and again, you're hashing that

Either:

Also FWIW I'd skip the mmap'ing for now - I suspect this case is not a slam dunk for perf, and getting it correct on all platforms will be a bit of a headache.

@lukewilliamboswell lukewilliamboswell merged commit 5b05aec into main Jul 9, 2025
24 checks passed
@lukewilliamboswell lukewilliamboswell deleted the module-cache branch July 9, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants