HT6 #37
Open
HT6 #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 9, 2019 11:24
* Не загружаются все комменты если были когда-то загружены
…comment?limit=5&offset=10) HT6.3 Загружаю каждую страницу только один раз
…считывается динамически. Пофиксил загрузкой первой страницы по умолчанию
motionrus
commented
Mar 10, 2019
| if (!loading && !pagesLoaded.includes(page) && fetchAll) { | ||
| fetchAll(DEFAULT_OFFSET * (page - 1), page) | ||
| } | ||
| }, [page]) |
There was a problem hiding this comment.
не знаю что это но чувствую что тут должно быть page. Если я правильно понял, это условие, при каких обстоятельствах вызывать useEffect
There was a problem hiding this comment.
Хороший вопрос для разбора в начале урока, задай в слаке
romabelka
reviewed
Mar 11, 2019
| const { loading, fetchAll, page, pagesLoaded } = props | ||
| useEffect(() => { | ||
| if (!loading && !pagesLoaded.includes(page) && fetchAll) { | ||
| fetchAll(DEFAULT_OFFSET * (page - 1), page) |
There was a problem hiding this comment.
я бы передавал page, а уже в AC превращал это в offset и limit
| if (!loading && !pagesLoaded.includes(page) && fetchAll) { | ||
| fetchAll(DEFAULT_OFFSET * (page - 1), page) | ||
| } | ||
| }, [page]) |
There was a problem hiding this comment.
Хороший вопрос для разбора в начале урока, задай в слаке
| loading: false, | ||
| loaded: false, | ||
| total: 0, | ||
| pagesLoaded: List([]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Первый коммит:
Второй коммит: