Skip to content

Add statistics collection to mock_components/GenericSystem #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndyZe opened this issue Nov 15, 2022 · 5 comments
Closed

Add statistics collection to mock_components/GenericSystem #463

AndyZe opened this issue Nov 15, 2022 · 5 comments

Comments

@AndyZe
Copy link
Contributor

AndyZe commented Nov 15, 2022

When running simulations, it would be nice to add statistics collection to mock_components/GenericSystem. For example:

  • What is the average rate of incoming commands?
  • What is the average latency (from message stamp to message received)?
  • What is the standard deviation of time between messages?

I think it would also be nice to add a service call to trigger this data collection so it doesn't begin until the user is ready.

I don't have any immediate need for this but it would have been nice on a few projects in the past.

Bonus if this can be done on hardware as well without breaking realtime constraints.

@mcbed
Copy link
Member

mcbed commented Nov 16, 2022

Hi Andy,
In terms of functionality inside the framework, does it change something to collect this data in a hardware interface rather than in a dedicated controller ? We use some of what you describe here but in a controller version to test our setups what allows us to collect data also if running a real hardware and I am curious if we could expect some different results.

@bmagyar
Copy link
Member

bmagyar commented Nov 17, 2022

For ros-controls/ros2_control#806 we used an instrumented JTC and instrumented mock hardware components

Copy link
Contributor

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale label Apr 11, 2025
Copy link
Contributor

This issue was closed because it has been stalled for 45 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2025
@christophfroehlich
Copy link
Contributor

This is implemented with ros-controls/ros2_control#2086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants