Chronicle official release chart cleanup #670
Draft
+1,770
−323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make most elements defined dynamically with overrides/merges rather than be hardcoded (e.g. resource names, namespaces, etc.) - Update references for changes to values.yaml - Change most label/annotation definitions to inline rather than bespoke helper definitions. - Reimplement persistence as a PVC resource rather than a volumeClaimTemplate. This also adds selection for existing PVCs. - Change configmap configuration key to be filename of the config file. Certain elements of the config will also be required when sections are enabled/disabled.
Provides base level of support for mounting things like certs/keys
- Add labels/annotations to statefulset
This reverts commit f683f81.
ianpittwood
requested review from
matt-urbina,
markrtucker,
t-margheim and
a team
as code owners
t-margheim
approved these changes
May 15, 2025
Comment on lines
+120
to
+124
| `retentionPeriod` controls how long usage data is retained. For example, `"120m"` | ||
| for 120 minutes, `"36h"` for 36 hours, `14d` for two weeks, or `"0"` for unbounded | ||
| retention. Units smaller than seconds or larger than days are not currently | ||
| supported. `retentionPeriod` does not apply to other types of data stored by | ||
| Chronicle. |
There was a problem hiding this comment.
This feature was recently moved to undocumented (see https://github.com/rstudio/chronicle/pull/2093), so we should probably remove references to it here as well.
| Logging: | ||
| # -- Specified the output for log messages, can be one of "STDOUT", "STDERR", or a file path |
There was a problem hiding this comment.
Suggested change
| # -- Specified the output for log messages, can be one of "STDOUT", "STDERR", or a file path | |
| # -- Specifies the output for log messages, can be one of "STDOUT", "STDERR", or a file path |
| Location: "./chronicle-data" | ||
| # -- The path to the local storage location | ||
| Path: "/opt/chronicle-data" | ||
| # -- The retention period for data before it is purged |
There was a problem hiding this comment.
Should probably also remove RetentionPeriod from here.
markrtucker
approved these changes
May 16, 2025
…e linting issues" This reverts commit 180b30a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extraSecretMountscan now be specified to mount additional secrets, such as certificates, into the pod.extraObjectsvalue.