Add Chronicle agent builtin sidecar definitions to Connect and Workbench #671
+310
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…brary helpers - Add initContainers chronicle agent definition to Workbench. - Update initContainers to include chronicle agent definition. - Add support for env and volumeMounts in definition. - Bump rstudio-library versions to 0.1.32. - Update READMEs with info on Chronicle agent. - Update NEWS notes. - Add serverNamespace value.
t-margheim
reviewed
May 15, 2025
| serverAddress: "" | ||
| # -- The namespace for the Chronicle server. If not set, the chart will attempt to look up the address of the Chronicle Server in the release namespace. | ||
| serverNamespace: "" | ||
|
|
There was a problem hiding this comment.
There should be a way to provide a Workbench API key here as well. This API key is optional for agents running alongside Workbench, but we need to provide a mechanism for a user who wants to to provide one.
markrtucker
reviewed
May 16, 2025
| @@ -261,6 +261,33 @@ ingress: | |||
| # hosts: | |||
| # - chart-example.local | |||
|
|
|||
| # -- Settings for the Chronicle Agent sidecar container | |||
| chronicleAgent: | |||
There was a problem hiding this comment.
I would have expected environment to be an option here. (This is related to the perhaps-poorly-named "environment" option for the agent: https://docs.posit.co/chronicle/appendix/library/advanced-agent.html#environment).
Maybe this is defined somewhere else?
| @@ -63,6 +63,30 @@ strategy: | |||
| maxSurge: "100%" | |||
| maxUnavailable: 0 | |||
|
|
|||
| # -- Settings for the Chronicle Agent sidecar container | |||
| chronicleAgent: | |||
There was a problem hiding this comment.
As above, I would expect environment to be here
Add not recommended input of value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initContainersdefinition for Chronicle agent to Workbench and Connect charts.rstudio-libraryto 0.1.32 in Workbench and Connect dependencies.