Skip to content

Add protocol to Chronicle serverAddress helper #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 20, 2025
Merged

Add protocol to Chronicle serverAddress helper #675

merged 6 commits into from
May 20, 2025

Conversation

ianpittwood
Copy link
Contributor

  • Add protocol (http or https) to Chronicle's serverAddress helper based on the exposed port name.
  • Fix left-hand whitespace trimming on helpers.

@ianpittwood ianpittwood requested review from a team as code owners May 20, 2025 14:45
@ianpittwood ianpittwood marked this pull request as draft May 20, 2025 14:46
@ianpittwood ianpittwood marked this pull request as ready for review May 20, 2025 14:50
@ianpittwood ianpittwood requested a review from bschwedler May 20, 2025 14:50
@ianpittwood ianpittwood merged commit 2efd61e into main May 20, 2025
7 checks passed
@ianpittwood ianpittwood deleted the chronicle/add-protocol-to-serverAddress-helper branch May 20, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschwedler bschwedler bschwedler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ianpittwood @bschwedler @actions-user