Skip to content

Add Attribution destination #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Attribution destination #29

wants to merge 4 commits into from

Conversation

mgz
Copy link

@mgz mgz commented May 11, 2022

Description of the change

Add https://www.attributionapp.com destination.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@mgz mgz force-pushed the attribution-destination branch from 70f46b9 to 2fb8b43 Compare May 11, 2022 13:32
@mgz mgz marked this pull request as ready for review May 12, 2022 18:44
shrouti1507
shrouti1507 reviewed May 16, 2022
View reviewed changes
@mgz mgz requested a review from shrouti1507 May 16, 2022 11:32
@shrouti1507 shrouti1507 requested a review from arnab-p May 16, 2022 15:04
@shrouti1507 shrouti1507 self-requested a review May 16, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnab-p arnab-p Awaiting requested review from arnab-p

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgz @shrouti1507