-
-
Notifications
You must be signed in to change notification settings - Fork 828
Translation tutorial 3 #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All reactions
-
👍 1 reaction
All reactions
Sorry, something went wrong.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Jzow , I have given some comments. Thanks for your work :)
Sorry, something went wrong.
All reactions
@colachg Thank you for reviewing, I try to modify |
All reactions
Sorry, something went wrong.
@colachg Hi, I have tried to modify it. Can you review it again? If ok, I will continue to translate the following chapters |
All reactions
Sorry, something went wrong.
Of course yes , can you please resolve all the comments that I left above if you have modified it or even you don't want to modify it? |
All reactions
Sorry, something went wrong.
please check, I have modified it and resolve all |
All reactions
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sorry, something went wrong.
All reactions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see m comment regarding the diff section that was falsely marked as resolved.
Sorry, something went wrong.
All reactions
Please check the english version, which is kept up-to-date. Don't have to translate this sentence into Chinese? My understanding is that it can be linked to the English version of diff, which can be seen clearly by users. This sentence should be translated If necessary, I will make another modification @colachg What do you think? |
All reactions
Sorry, something went wrong.
Okay for me to translate this sentence 👍 |
All reactions
-
👍 1 reaction
Sorry, something went wrong.
Please open one PR per chapter. That makes reviewing easier for others. It seems that for tutorial 3, you still have the English sentence for
In tutorial 4, it is translated already. |
All reactions
Sorry, something went wrong.
First, I temporarily removed the translation in Chapter 4, and then opened a new pr for each translation in Chapter 4. In addition, I modified the diff in Chapter 2 and Chapter 3 |
All reactions
Sorry, something went wrong.
Thanks a lot! |
All reactions
Sorry, something went wrong.
colachg
andre-richter
Successfully merging this pull request may close these issues.
None yet
Description
Related Issue:
Pre-commit steps
./contributor_setup.sh
followed by./devtool ready_for_publish
Ruby
withBundler
andNPM
installed locally../devtool ready_for_publish_no_rust
can be used instead (faster).