change Ubuntu to Debian-based distros #4376
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sentence is correct for all Debian-based distros like Mint and Pop OS as well as Ubuntu.
celestius0
reviewed
May 30, 2025
src/ch01-01-installation.md
Outdated
Comment on lines
55
to
56
| distribution’s documentation. For example, if you use Debian-based distros, you can install | ||
| the `build-essential` package. |
There was a problem hiding this comment.
If we're adjusting to a more generic example, might as well provide the install command as well:
Suggested change
| distribution’s documentation. For example, if you use Debian-based distros, you can install | |
| the `build-essential` package. | |
| distribution’s documentation. For example, in Debian-based distros you can install | |
| the `build-essential` package via: | |
| ```console | |
| $ sudo apt install build-essential | |
| ``` |
There was a problem hiding this comment.
I agree, but omitted "via" because I believe it helps with clarity (keeps the connection with the previous sentence better).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sentence is correct for all Debian-based distros like Mint and Pop OS as well as Ubuntu.