Skip to content

Use walkdir to ensure all style files trigger rebuilding #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2020
Merged

Use walkdir to ensure all style files trigger rebuilding #1117

merged 1 commit into from
Oct 26, 2020

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Oct 22, 2020

No more manually updating the file list, just assume that all files within the include_paths might affect the output.

@jyn514
Copy link
Member

jyn514 commented Oct 23, 2020

Cargo.toml has a conflict, but looks fine otherwise.

@jyn514 jyn514 added A-newcomer-roadblock Area: A problem that isn't a bug, but makes it harder for people to contribute S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 23, 2020
@jyn514 jyn514 merged commit 073b903 into rust-lang:master Oct 26, 2020
@Nemo157 Nemo157 deleted the fix-build-rerun branch October 26, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixiron Kixiron Kixiron approved these changes

Assignees
No one assigned
Labels
A-newcomer-roadblock Area: A problem that isn't a bug, but makes it harder for people to contribute S-waiting-on-author Status: This PR is incomplete or needs to address review comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nemo157 @jyn514 @Kixiron