Detect theme changes on all docs.rs pages #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to change non-rustdoc pages if another open tab is looking at a rustdoc page and changes the theme
jyn514
reviewed
Oct 26, 2020
Comment on lines
+5
to
+16
| window.addEventListener('storage', function (ev) { | ||
| if (ev.key === 'rustdoc-theme') { | ||
| applyTheme(ev.newValue); | ||
| } | ||
| }); | ||
|
|
||
| // see ../static/storage-change-detection.html for details | ||
| window.addEventListener('message', function (ev) { | ||
| if (ev.data && ev.data.storage && ev.data.storage.key === 'rustdoc-theme') { | ||
| applyTheme(ev.data.storage.value); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Do we need both of these listeners? Could we only listen to storage and get rid of the iframe?
There was a problem hiding this comment.
Then we miss out on knowing when this current window changes the theme, we would only update when another window changes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to change non-rustdoc pages if another open tab is looking at a rustdoc page and changes the theme.