Skip to content

Use a minimal stylesheet for the navbar on rustdoc pages #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Oct 28, 2020

If for some reason rustdoc fails to apply the current theme (e.g. it's set to ayu and it's old docs that don't have that theme) then this will result in the navbar applying the theme, but the rustdoc output will fallback to the light theme without interference.

We also don't bother loading the rustdoc specific overrides on non-rustdoc pages.

image

fixes #1126

@jyn514 jyn514 added A-frontend Area: Web frontend S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 28, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 28, 2020

Seems reasonable.

@jyn514 jyn514 merged commit 27dcd99 into rust-lang:master Oct 28, 2020
@Nemo157 Nemo157 deleted the fix-style-on-old-rustdoc branch May 31, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Web frontend S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old docs look bad if current theme is ayu
2 participants