Support either proc-macro or proc_macro keys #1604
Conversation
|
I won't be able to grab the list just now, it requires checking all crates published since 2021-11-27, which is before the latest index squash, and probably >30k to download and check 😰. I might get around to it later, otherwise for now we know of |
IMO that's good enough. |
|
Ah I just reworked Cargo.toml and republished so I guess no need for a rebuild for |
syphar
added
the
S-waiting-on-review
| let metadata = Metadata::from_str(manifest).unwrap(); | ||
| assert!(metadata.proc_macro); | ||
|
|
||
| // Cargo prioritizes `proc-macro` over `proc_macro` in local testing |
There was a problem hiding this comment.
That seems like an upstream bug, it should probably give a hard error if they conflict ... but shouldn't affect what docs.rs does.
There was a problem hiding this comment.
Yep, but there could be existing crates published with it so I wanted to make sure we matched the behavior.
There was a problem hiding this comment.
And by mentioning it on discord I managed to persuade someone to file an issue 😀 rust-lang/cargo#10299
There was a problem hiding this comment.
It sounds like this would only warn when you use both at the same time,
so supporting either key IMO still the right thing to do on docs.rs
syphar
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Fix for the issue in #1602
I'll try to get a list of crates that need rebuilding.