Use pull_request_target event type for labeling
#1643
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will run in the context of the target branch, so have write permissions even when the PR is from a fork.
GuillaumeGomez
approved these changes
Jan 29, 2022
GuillaumeGomez
added
the
S-waiting-on-review
|
@Nemo157 @GuillaumeGomez I'm confused, is this PR here merged or not? I see the commit itself and the merge-commit on master, while this PR is still open? |
|
Good question. GitHub seems to have confused itself while merging. When I tried to close last night it wouldn't let me too, hopefully it does now. |
syphar
pushed a commit
to syphar/docs.rs
that referenced
this pull request
Jan 30, 2022
Use `pull_request_target` event type for labeling
syphar
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will run in the context of the target branch, so have write permissions even when the PR is from a fork.