Skip to content

Add date alongside release version #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jun 19, 2025

Fixes #2845.

The result looks like this:

image

@syphar: I also commited sqlx files but not sure if I should have.

@GuillaumeGomez GuillaumeGomez requested a review from a team as a code owner June 19, 2025 16:35
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jun 19, 2025
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement!

( just running just sqlx-prepare should fix the issues, I could also do it if you're not sure )

@GuillaumeGomez
Copy link
Member Author

Well I did it (or thought I did). Let's see if I didn't fail it this time.

@GuillaumeGomez
Copy link
Member Author

Seems like it's still wrong. Do I need something else apart from just sqlx-prepare?

@syphar
Copy link
Member

syphar commented Jun 19, 2025

Seems like it's still wrong. Do I need something else apart from just sqlx-prepare?

migrations applied in your local database?

@GuillaumeGomez
Copy link
Member Author

Everything applied, migrations done. It still generates the same file I uploaded here.

@syphar
Copy link
Member

syphar commented Jun 20, 2025

that's super odd, I don't like how this happens sometimes to devs.

I think I remember one occasion where I had a similar issue, and solved it by using a fresh database, running the migrations, and then trying it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please include release date information in version info
2 participants