This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Make the compiler-builtins test more accurately mirror compiler-builtins #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
builtins-test-update
branch
2 times, most recently
from
a86f068 to
ce145a6
Compare
Pin aarch64-unknown-linux-gnu and aarch64-apple-darwin to nightly-2025-02-07 until [1] makes it to a Rust nightly. [1]: llvm/llvm-project#127804
In `compiler-builtins`, `libm` is contained within a `math` module. The smoke test in this repo has a slightly different layout so some things were passing that shouldn't be. Change module layouts in `compiler-builtins-smoke-test` to match `compiler-builtins` and update a few instances of broken paths.
tgross35
force-pushed
the
builtins-test-update
branch
from
ce145a6 to
0fb8270
Compare
|
Added a CI patch like rust-lang/compiler-builtins@b2bcfc8 since the same issues are popping up here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
compiler-builtins,libmis contained within amathmodule. The smoke test in this repo has a slightly different layout so some things were passing that shouldn't be.Change module layouts in
compiler-builtins-smoke-testto matchcompiler-builtinsand update a few instances of broken paths.