Skip to content

Configure flycheck using workspace.discoverConfig #18043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
+583 −131
Open

Configure flycheck using workspace.discoverConfig #18043

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
408973f
PackageToRestart (kinda works?)
cormacrelf Sep 4, 2024
5893442
$label placeholder in overrideCommand
cormacrelf Sep 4, 2024
e67e75a
flycheck::PackageSpecifier
cormacrelf Sep 4, 2024
e697333
Fix flycheck running on a random downstream crate
cormacrelf Sep 4, 2024
07f2ac4
project_json_flycheck
cormacrelf Sep 4, 2024
5d69431
If $label in check command, only flycheck crates with a label in rust…
cormacrelf Sep 4, 2024
108ebb9
use explicit_check_command
cormacrelf Sep 4, 2024
98fc4b9
Early return in flycheck
cormacrelf Sep 4, 2024
8e5e8f7
return crate by reference
cormacrelf Sep 4, 2024
995500b
Use runnable + substitutions to do override commands
cormacrelf Sep 4, 2024
9aa4b0b
RunnableKindData::Flycheck
cormacrelf Sep 4, 2024
52d3d33
Document FlycheckActor.manifest_path
cormacrelf Sep 4, 2024
a3815ce
Always allow flychecking single crate if there is a build label from …
cormacrelf Sep 4, 2024
7322f78
flycheck: notifications show full command when configured in a rust-p…
cormacrelf Sep 4, 2024
dc85a4d
Pretty-print the custom flycheck command with fewer quote characters
cormacrelf Sep 4, 2024
52354dc
Better debug logging in flycheck
cormacrelf Sep 4, 2024
ac3b604
Also notify the full command if you set check.overrideCommand
cormacrelf Sep 4, 2024
48cbf73
FlycheckScope, never look for downstream deps if check.workspace is f…
cormacrelf Sep 4, 2024
c24bf18
Set iteration order of reverse deps to be topological
cormacrelf Sep 5, 2024
1d3cac1
flycheck.cannot_run_workspace
cormacrelf Sep 5, 2024
cb9440e
Fix using the non-canonical target name sometimes for flychecks
cormacrelf Sep 5, 2024
65c60e1
Target -> BinTarget refactor, embed it in flycheck::PackageSpecifier:…
cormacrelf Sep 5, 2024
6c0ab17
BinTarget avoids attaching --bin when the package is one other than t…
cormacrelf Sep 5, 2024
09ef79a
Make the fake flycheck path work on windows
cormacrelf Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
RunnableKindData::Flycheck
  • Loading branch information
@cormacrelf
cormacrelf committed Sep 4, 2024
commit 9aa4b0b4ebc26f028adad1976699f91c22e54108
2 changes: 2 additions & 0 deletions crates/project-model/src/project_json.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,7 @@ pub struct RunnableData {
#[derive(Debug, Clone, PartialEq, Eq, Deserialize, Serialize)]
#[serde(rename_all = "camelCase")]
pub enum RunnableKindData {
Flycheck,
Check,
Run,
TestOne,
Expand Down Expand Up @@ -497,6 +498,7 @@ impl From<RunnableKindData> for RunnableKind {
RunnableKindData::Check => RunnableKind::Check,
RunnableKindData::Run => RunnableKind::Run,
RunnableKindData::TestOne => RunnableKind::TestOne,
RunnableKindData::Flycheck => RunnableKind::Flycheck,
}
}
}
Expand Down