fix: Copy lockfiles into target directory before invoking cargo metadata
#20018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way we no longer modify lockfiles on startup, as
metadata
is not considered a read-only operation by the cargo team. This also makes our sysroot loading more resilient, as we no longer have to pass--locked
to it which could make the loading fail. This should allow us to remove the stitched sysroot as well now.Only has an affect on toolchains >= 1.82.
Fixes #19729
Fixes #10792
Fixes #19667
cc #12499