Skip to content

fix: Copy lockfiles into target directory before invoking cargo metadata #20018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jun 17, 2025

That way we no longer modify lockfiles on startup, as metadata is not considered a read-only operation by the cargo team. This also makes our sysroot loading more resilient, as we no longer have to pass --locked to it which could make the loading fail. This should allow us to remove the stitched sysroot as well now.

Only has an affect on toolchains >= 1.82.

Fixes #19729
Fixes #10792
Fixes #19667
cc #12499

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 17, 2025
@Veykril Veykril force-pushed the push-pkowrtoturkr branch 2 times, most recently from d7b4d8a to f213cec Compare June 17, 2025 07:13
Comment on lines -430 to +482
locked,
true,
locked,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bools considered evil strikes again

@Veykril Veykril added this pull request to the merge queue Jun 17, 2025
@Veykril Veykril removed this pull request from the merge queue due to a manual request Jun 17, 2025
@Veykril Veykril force-pushed the push-pkowrtoturkr branch from f213cec to 72dc3fd Compare June 17, 2025 08:02
@Veykril Veykril force-pushed the push-pkowrtoturkr branch from 72dc3fd to c0f428d Compare June 17, 2025 08:09
@Veykril Veykril enabled auto-merge June 17, 2025 08:09
@Veykril Veykril added this pull request to the merge queue Jun 17, 2025
Merged via the queue into rust-lang:master with commit a31e10a Jun 17, 2025
14 checks passed
@Veykril Veykril deleted the push-pkowrtoturkr branch June 17, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
2 participants