fix: Never make type mismatch diagnostic stable, even when there is a fix #20022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We show fixes now even for experimental diagnostics anyway, and it has false positives.
rustbot
added
the
S-waiting-on-review
|
Type mismatches are probably the most useful diagnostics there are, I don't think marking them as experimental is a good idea. In the few cases where we are incorrect due to trait solving, people can usually work around it with an extra binding + explicit type annotation if needed. |
|
It's already experimental, it was just marked stable when there was a fix (presumably to show the fix), but now we show the fix anyway. We can discuss stabilizing it, but IMHO the bar for stable diagnostic should be "never has false positive on real code", and this one has many. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We show fixes now even for experimental diagnostics anyway, and it has false positives.
Fixes #20021.