Salsa idiomize VariantFields query
#20106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
commented
Jun 26, 2025
| @@ -697,7 +696,7 @@ fn main() { | |||
| "function_signature_with_source_map_shim", | |||
| "expr_scopes_shim", | |||
| "struct_signature_with_source_map_shim", | |||
| "variant_fields_with_source_map_shim", | |||
| "query_", | |||
There was a problem hiding this comment.
This will be fixed by salsa-rs/salsa#927
|
Why can't we just leave it as two queries? |
Veykril
force-pushed
the
push-pytuxksnntux
branch
from
6f9ab0f to
4687261
Compare
rustbot
added
the
S-waiting-on-review
|
Brought the firewall query back for now (fwiw looks like the extra query is a difference of 2mb on self) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.