Skip to content

Salsa idiomize VariantFields query #20106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025
Merged

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jun 26, 2025

No description provided.

@@ -697,7 +696,7 @@ fn main() {
"function_signature_with_source_map_shim",
"expr_scopes_shim",
"struct_signature_with_source_map_shim",
"variant_fields_with_source_map_shim",
"query_",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be fixed by salsa-rs/salsa#927

@ChayimFriedman2
Copy link
Contributor

Why can't we just leave it as two queries?

@Veykril Veykril force-pushed the push-pytuxksnntux branch from 6f9ab0f to 4687261 Compare June 26, 2025 12:13
@Veykril Veykril marked this pull request as ready for review June 26, 2025 12:14
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2025
@Veykril
Copy link
Member Author

Veykril commented Jun 26, 2025

Brought the firewall query back for now (fwiw looks like the extra query is a difference of 2mb on self)

@Veykril Veykril added this pull request to the merge queue Jun 26, 2025
Merged via the queue into rust-lang:master with commit 317c76f Jun 26, 2025
14 checks passed
@Veykril Veykril deleted the push-pytuxksnntux branch June 26, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants