Skip to content

compiletest "Blessing the {stream} of {test_name} in {expected_path:?}" test name is incorrect #140945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jieyouxu opened this issue May 12, 2025 · 0 comments · May be fixed by #140953
Open

compiletest "Blessing the {stream} of {test_name} in {expected_path:?}" test name is incorrect #140945

jieyouxu opened this issue May 12, 2025 · 0 comments · May be fixed by #140953
Assignees
@jieyouxu
Labels
A-compiletest Area: The compiletest test runner C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jieyouxu
Copy link
Member

https://github.com/rust-lang/rust/blob/bc7512ee6309ee7e8cacf87b94aa6d1f550c9d99/src/tools/compiletest/src/runtest.rs#L2651C27-L2651C84

Looks like it was incorrectly assigned a compare mode instead

rust/src/tools/compiletest/src/runtest.rs

Lines 2612 to 2613 in bc7512e

// Write the actual output to a file in build/
let test_name = self.config.compare_mode.as_ref().map_or("", |m| m.to_str());

@jieyouxu jieyouxu self-assigned this May 12, 2025
@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. A-compiletest Area: The compiletest test runner labels May 12, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 12, 2025
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 12, 2025
@jieyouxu jieyouxu linked a pull request May 12, 2025 that will close this issue
Open
bors added a commit to rust-lang-ci/rust that referenced this issue May 14, 2025
@bors
Auto merge of rust-lang#140953 - jieyouxu:compiletest-bless-msg, r=co…
c0ac7d5 
…mpiler-errors

Fix a compiletest blessing message

It was showing compare mode instead of test name.

Fixes rust-lang#140945.
Noticed in rust-lang#140622 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jieyouxu jieyouxu

Labels
A-compiletest Area: The compiletest test runner C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a compiletest blessing message jieyouxu/rust
2 participants
@jieyouxu @rustbot