Skip to content

Fix a compiletest blessing message #140953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix a compiletest blessing message #140953

wants to merge 1 commit into from
+12 −8

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented May 12, 2025 •
edited
Loading

It was showing compare mode instead of test name.

Fixes #140945.
Noticed in #140622 (comment).

@jieyouxu
compiletest: fix "blessing" message
82fbbc0 
It was showing compare mode instead of test name.
@rustbot
Copy link
Collaborator

rustbot commented May 12, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 12, 2025
@compiler-errors
Copy link
Member

r? compiler-errors

@rustbot rustbot assigned compiler-errors and unassigned oli-obk May 12, 2025
@jieyouxu
Copy link
Member Author

@bors r=@compiler-errors rollup

@bors
Copy link
Collaborator

bors commented May 13, 2025

📌 Commit 82fbbc0 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2025
@bors
Auto merge of rust-lang#140953 - jieyouxu:compiletest-bless-msg, r=co…
c0ac7d5 
…mpiler-errors

Fix a compiletest blessing message

It was showing compare mode instead of test name.

Fixes rust-lang#140945.
Noticed in rust-lang#140622 (comment).
@bors
Copy link
Collaborator

bors commented May 14, 2025

⌛ Testing commit 82fbbc0 with merge c0ac7d5...

@bors
Copy link
Collaborator

bors commented May 14, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compiletest "Blessing the {stream} of {test_name} in {expected_path:?}" test name is incorrect
5 participants
@jieyouxu @rustbot @compiler-errors @bors @oli-obk