Skip to content

Stabilize <[T; N]>::as_mut_slice as const #140066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stabilize <[T; N]>::as_mut_slice as const #140066

wants to merge 1 commit into from

Conversation

thaliaarchi
Copy link
Contributor

@thaliaarchi thaliaarchi commented Apr 20, 2025 •
edited
Loading

This is trivial and has no design questions.

Tracked in #133333.

r? libs-api

@rustbot
Copy link
Collaborator

rustbot commented Apr 20, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 20, 2025
@thaliaarchi thaliaarchi mentioned this pull request Apr 20, 2025
Open
3 tasks
@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 20, 2025
@rustbot rustbot assigned BurntSushi and unassigned ibraheemdev Apr 20, 2025
@jhpratt
Copy link
Member

jhpratt commented Apr 21, 2025

r? jhpratt

r=me with completed FCP

@rustbot rustbot assigned jhpratt and unassigned BurntSushi Apr 21, 2025
@BurntSushi

This comment was marked as outdated.

Sign in to view
@rfcbot

This comment was marked as outdated.

Sign in to view
@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Apr 21, 2025
@BurntSushi

This comment was marked as outdated.

Sign in to view
@rfcbot

This comment was marked as outdated.

Sign in to view
@rfcbot rfcbot removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Apr 21, 2025
@BurntSushi BurntSushi removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 21, 2025
@BurntSushi
Copy link
Member

@rfcbot fcp merge

@rfcbot
Copy link
Collaborator

rfcbot commented Apr 21, 2025 •
edited by dtolnay
Loading

Team member @BurntSushi has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Apr 21, 2025
@rfcbot
Copy link
Collaborator

rfcbot commented Apr 21, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels May 1, 2025
@rfcbot
Copy link
Collaborator

rfcbot commented May 1, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label May 1, 2025
@rustbot rustbot mentioned this pull request May 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhpratt jhpratt

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thaliaarchi @rustbot @jhpratt @BurntSushi @rfcbot @ibraheemdev