Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
std::os::windows::ffi::EncodeWide
is reexported fromstd::sys_common::wtf8::EncodeWide
, which has#![allow(missing_debug_implementations)]
in the parent module, it does not implementDebug
. Implement it akin tocore::str::Chars
.The only question is how to format each WTF-16 code unit. We can't format it like
char
, because \u escape sequences for surrogate halves are invalid syntax in Rust. It would be nice to format them as hex integers, but I am not aware of other instances of that pattern forDebug
instd
. Settle for decimal.This becomes insta-stable.
r? libs-api