Match on lang item kind instead of using an if/else chain

[oli-obk]

Similar to how the new solver does this. Just noticed while I was adding a new entry to the chain 😆

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 7454d4c with merge 4ef08a1...

[bors]

☀️ Try build successful - checks-actions
Build commit: 4ef08a1 (4ef08a1befdf4932d9a8347d7a318b04930aa148)

[Kobzol]

Could also make sense to order these by frequency of occurrence, although PGO might already do that.

[rust-timer]

Finished benchmarking commit (4ef08a1): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.2%]	38
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-0.8%, -0.2%]	38

Max RSS (memory usage)

Results (primary 0.9%, secondary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.4%, 3.1%]	16
Regressions ❌ (secondary)	3.0%	[2.8%, 3.2%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.9%	[0.4%, 3.1%]	16

Cycles

Results (primary -0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.7%, -0.5%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-0.7%, -0.5%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 761.588s -> 762.112s (0.07%)
Artifact size: 365.21 MiB -> 365.01 MiB (-0.05%)

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 7d3e707 with merge 2658a39...

[bors]

☀️ Try build successful - checks-actions
Build commit: 2658a39 (2658a39b26bea05b2383c33dce1cbcd22491e4cf)

[rust-timer]

Finished benchmarking commit (2658a39): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.2%]	36
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.8%, 2.9%]	37

Max RSS (memory usage)

Results (primary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.5%, 0.9%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.6%, 0.9%]	4

Cycles

Results (primary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[0.5%, 3.1%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.7%, -0.5%]	5
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.7%, 3.1%]	7

Binary size

Results (primary 1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[1.1%, 1.1%]	1

Bootstrap: 761.378s -> 762.587s (0.16%)
Artifact size: 365.18 MiB -> 365.02 MiB (-0.04%)

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 03c05c9 with merge d1eb1a6...

[bors]

☀️ Try build successful - checks-actions
Build commit: d1eb1a6 (d1eb1a60485bcf3be32e02227a450e45090873a9)

[rust-timer]

Finished benchmarking commit (d1eb1a6): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.5%, 0.5%]	2
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.2%]	39
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.2%]	3
All ❌✅ (primary)	-0.4%	[-0.8%, -0.2%]	39

Max RSS (memory usage)

Results (primary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.4%, 0.7%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-2.2%, -0.5%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-2.2%, 0.7%]	7

Cycles

Results (primary -0.2%, secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.6%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	3
Improvements ✅ (secondary)	-2.2%	[-2.5%, -1.8%]	4
All ❌✅ (primary)	-0.2%	[-0.6%, 0.6%]	5

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 764.09s -> 764.031s (-0.01%)
Artifact size: 365.39 MiB -> 365.21 MiB (-0.05%)