Skip to content

early migration to biome #140594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lolbinarycat
Copy link
Contributor

noUnusedVariables and useCollapsedElseIf lints disabled due to causing a bunch of warnings

noUnusedVariables and useCollapsedElseIf lints disabled due to causing a bunch of warnings
@rustbot
Copy link
Collaborator

rustbot commented May 2, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels May 2, 2025
@GuillaumeGomez
Copy link
Member

What why should we migrate to biome? Is there something it does that eslint doesn't maybe?

@lolbinarycat
Copy link
Contributor Author

I'm still not 100% sold on migration, as biome is significantly younger as a project, which does come with stability concerns.

however, there are many potential advantages:

  1. merging of formatter and linter into a single tool, reducing the number of external deps to manage
  2. dogfooding, using tools written in rust to develop rust tools, this can potentially lead to more communication between the teams, potentially improving both biome and rust
  3. performance
  4. i believe biome has a number of lints that eslint lacks (although the inverse is likely also true)

We're going to want to do some form of migration if we stick with eslint or not, which does offset some of the switching costs.

I think it's good to analyze both options.

This draft is mostly here for reference, since I already did this work to figure out how hard it would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants