Skip to content

Clarify upfront that PartialOrd is for strict partial orders #140779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Muon
Copy link

@Muon Muon commented May 8, 2025

Fixes #140654.

@rustbot
Copy link
Collaborator

rustbot commented May 8, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 8, 2025
@Mark-Simulacrum Mark-Simulacrum added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 13, 2025
@Mark-Simulacrum
Copy link
Member

I'm going to move this to the libs-api agenda -- maybe we can find someone better suited to review this. It's not clear to me from the description in the issue (#140654) whether this is actually a semantic change or not in what we're promising -- it seems like it is maybe not, based on the diff, but I'm a little confused why we didn't land on this when initially landing the docs here.

@Muon
Copy link
Author

Muon commented May 13, 2025

I do not believe this a semantic change. That would require the changed sentences to be normative, but that's impossible unless f32 and f64 are not meant to be PartialOrd, since their <= is already not a partial order.

Also note that the docs later clarify that this is indeed for strict partial orders only: https://doc.rust-lang.org/std/cmp/trait.PartialOrd.html#strict-and-non-strict-partial-orders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PartialOrd does not mention upfront that it omits reflexivity
3 participants