Prefer to suggest stable candidates rather than unstable ones #140795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @petrochenkov. Use |
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
rustbot
added
S-waiting-on-review
petrochenkov
reviewed
May 8, 2025
petrochenkov
added
S-waiting-on-author
mu001999
force-pushed
the
sugg-stable-import-first
branch
from
76e7050 to
7b0ff5c
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
petrochenkov
added
S-waiting-on-author
mu001999
force-pushed
the
sugg-stable-import-first
branch
from
7b0ff5c to
7c253ac
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 11, 2025
Rollup of 7 pull requests Successful merges: - rust-lang#140792 (Use intrinsics for `{f16,f32,f64,f128}::{minimum,maximum}` operations) - rust-lang#140795 (Prefer to suggest stable candidates rather than unstable ones) - rust-lang#140865 (Make t letter looks like lowercase rather than uppercase) - rust-lang#140878 (Two expand-related cleanups) - rust-lang#140882 (Split duration_constructors to get non-controversial constructors out) - rust-lang#140886 (Update deps of bootstrap for Cygwin) - rust-lang#140903 (test intrinsic fallback bodies with Miri) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 11, 2025
Rollup merge of rust-lang#140795 - mu001999-contrib:sugg-stable-import-first, r=petrochenkov Prefer to suggest stable candidates rather than unstable ones Fixes rust-lang#140240 The logic is to replace unstable suggestions if we meet a new stable one, and do nothing if any other situation. In old logic, we just use the first candidate we meet as the suggestion for the same items. E.g., `std::range::legacy::Range` vs `std::ops::Range`, `legacy` in the former is unstable, we prefer to suggest use the latter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140240
The logic is to replace unstable suggestions if we meet a new stable one, and do nothing if any other situation. In old logic, we just use the first candidate we meet as the suggestion for the same items.
E.g.,
std::range::legacy::Rangevsstd::ops::Range,legacyin the former is unstable, we prefer to suggest use the latter.