Skip to content

[CRATER] probe fallout of dyn overlap #140824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[CRATER] probe fallout of dyn overlap #140824

wants to merge 2 commits into from

Conversation

compiler-errors
Copy link
Member

r? lcnr for vibes, not to merge obviously

@compiler-errors
Copy link
Member Author

@bors try

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 8, 2025
@bors
Copy link
Collaborator

bors commented May 8, 2025

⌛ Trying commit c0d717f with merge 081e5d3...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 8, 2025
@bors
Auto merge of rust-lang#140824 - compiler-errors:typing-mode, r=<try>
081e5d3 
[CRATER] probe fallout of `dyn` overlap

r? lcnr for vibes, not to merge obviously
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented May 8, 2025

💔 Test failed - checks-actions

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2025
@compiler-errors
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented May 9, 2025

⌛ Trying commit d3c50fc with merge 7d2afcd...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 9, 2025
@bors
Auto merge of rust-lang#140824 - compiler-errors:typing-mode, r=<try>
7d2afcd 
[CRATER] probe fallout of `dyn` overlap

r? lcnr for vibes, not to merge obviously
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
    ---- rust-2024/rpit-lifetime-capture.md - RPIT_lifetime_capture_rules::Migration::Migrating_away_from_the_ (line 197) stdout ----
    error: hi
     --> rust-2024/rpit-lifetime-capture.md:200:1
      |
    4 | pub trait Captures<T: ?Sized> {}
      | ----------------------------- built-in `dyn Captures<_>` implementation for this trait
    5 | impl<T: ?Sized, U: ?Sized> Captures<T> for U {}
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ overlaps with this blanket impl
      |
      = note: `#[forbid(dyn_overlap)]` on by default
    
    error: aborting due to 1 previous error
    
    Couldn't compile the test.

@bors
Copy link
Collaborator

bors commented May 9, 2025

☀️ Try build successful - checks-actions
Build commit: 7d2afcd (7d2afcda7a9c043d5175cbca3ab08f0acf02b13a)

@lcnr
Copy link
Contributor

lcnr commented May 9, 2025

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-140824 created and queued.
🤖 Automatically detected try build 7d2afcd
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 9, 2025
@craterbot
Copy link
Collaborator

🚧 Experiment pr-140824 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-140824 is completed!
📊 541 regressed and 4 fixed (628353 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @bors @rust-log-analyzer @lcnr @craterbot @rustbot