-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Merge mir query analysis invocations #140856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Merge mir query analysis invocations r? `@ghost` same thing as rust-lang#140854 just a different set of queries
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (bddede8): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.9%, secondary -2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 1.5%, secondary 0.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 773.559s -> 774.531s (0.13%) |
@Zoxc do you think changes like this are detrimental to parallel rustc? |
Merging parallel sections is generally good, but actual measurements are also nice. |
Right. I'll figure out how to do that locally. But until then r? @nnethercote |
Ah no I forgot the regression only shows in cycles, not in instructions... |
Branch misses and cache misses are also really badly regressed. So my original analysis still stands, even if wall time itself is not really affected |
r? @ghost
same thing as #140854 just a different set of queries