-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix typos #140935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #140935
Conversation
r? @davidtwco rustbot has assigned @davidtwco. Use |
Some changes occurred in compiler/rustc_codegen_ssa The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. cc @BoxyUwU, @jieyouxu, @Kobzol The Miri subtree was changed cc @rust-lang/miri Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not do shotgun spelling fixes like this.
- The windows binding change is actually wrong.
- Several changes here affect tools, that while can be josh-synced, do not justify changing them in r-l/r instead of their own repos. This increase sync conflicts just for typo fixes. This includes the clippy, rust-analyzer, and rustc-dev-guide changes.
I'm okay with accepting only the compiler/*
and src/doc/rustc/*
changes, but please drop all other changes.
@rustbot author |
Reminder, once the PR becomes ready for a review, use |
@rustbot ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Can you squash the commits into one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
r? jieyouxu @bors r+ rollup |
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 3ae0b2e (parent) -> 32d2385 (this PR) Test differencesShow 33150 test diffsStage 1
Stage 2
(and 16504 additional test diffs) Additionally, 16546 doctest diffs were found. These are ignored, as they are noisy. Job group index Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 32d23857f168a71bd0e77b17c0984b567461f7dc --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (32d2385): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 1.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 0.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 771.806s -> 772.321s (0.07%) |
Fix typos