Skip to content

ui/async-drop-initial: factor in panic strategy in destructor size check #140941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

japaric
Copy link
Member

@japaric japaric commented May 12, 2025

the size of AsyncStruct's destructor depends on whether the configured panic strategy is 'unwind' or 'abort' so factor that into the test using conditional compilation

fixes #140939
fixes #140493

the size of `AsyncStruct`'s destructor depends on whether the configured
panic strategy is 'unwind' or 'abort' so factor that into the test using
conditional compilation

fixes rust-lang#140939
@rustbot
Copy link
Collaborator

rustbot commented May 12, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 12, 2025
@petrochenkov petrochenkov added the F-async_drop `#![feature(async_drop)]` label May 12, 2025
@petrochenkov
Copy link
Contributor

r? @petrochenkov
@bors r+

@bors
Copy link
Collaborator

bors commented May 12, 2025

📌 Commit 2fdf3d9 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 12, 2025
…-test, r=petrochenkov

ui/async-drop-initial: factor in panic strategy in destructor size check

the size of `AsyncStruct`'s destructor depends on whether the configured panic strategy is 'unwind' or 'abort' so factor that into the test using conditional compilation

fixes rust-lang#140939
fixes rust-lang#140493
@bors
Copy link
Collaborator

bors commented May 12, 2025

⌛ Testing commit 2fdf3d9 with merge a4800b9...

@rust-log-analyzer
Copy link
Collaborator

The job dist-x86_64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[1682/3708] Building PPCGenInstrInfo.inc...
[1683/3708] Building PPCGenRegisterInfo.inc...
[1684/3708] Building PPCGenSubtargetInfo.inc...
[1685/3708] Building RISCVGenAsmMatcher.inc...
FAILED: lib/Target/RISCV/RISCVGenAsmMatcher.inc /Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build/lib/Target/RISCV/RISCVGenAsmMatcher.inc 
cd /Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build && /Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build/bin/llvm-tblgen -gen-asm-matcher -I /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target/RISCV -I/Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build/include -I/Users/runner/work/rust/rust/src/llvm-project/llvm/include -I /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target -no-warn-on-unused-template-args /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target/RISCV/RISCV.td --write-if-changed -o lib/Target/RISCV/RISCVGenAsmMatcher.inc -d lib/Target/RISCV/RISCVGenAsmMatcher.inc.d
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0. Program arguments: /Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build/bin/llvm-tblgen -gen-asm-matcher -I /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target/RISCV -I/Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build/include -I/Users/runner/work/rust/rust/src/llvm-project/llvm/include -I /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target -no-warn-on-unused-template-args /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target/RISCV/RISCV.td --write-if-changed -o lib/Target/RISCV/RISCVGenAsmMatcher.inc -d lib/Target/RISCV/RISCVGenAsmMatcher.inc.d
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  llvm-tblgen              0x000000010358e887 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 39
1  llvm-tblgen              0x000000010358ca78 llvm::sys::RunSignalHandlers() + 248
2  llvm-tblgen              0x000000010358ef20 SignalHandler(int) + 272
3  libsystem_platform.dylib 0x00007ff8126445ed _sigtramp + 29
4  libsystem_platform.dylib 0x0000000000000010 _sigtramp + 18446603370272373312
5  libsystem_c.dylib        0x00007ff81253db45 abort + 123
6  libsystem_malloc.dylib   0x00007ff812454752 malloc_vreport + 888
7  libsystem_malloc.dylib   0x00007ff812457b31 malloc_report + 151
8  llvm-tblgen              0x0000000103375ef9 llvm::Record::~Record() + 153
9  llvm-tblgen              0x0000000103595a8d llvm::RecordsEntry::~RecordsEntry() + 157
10 llvm-tblgen              0x0000000103595b6c std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, void*>*) + 108
11 llvm-tblgen              0x0000000103595b22 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, void*>*) + 34
12 llvm-tblgen              0x0000000103595b22 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, void*>*) + 34
13 llvm-tblgen              0x0000000103595b2e std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, void*>*) + 46
14 llvm-tblgen              0x0000000103595b22 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, void*>*) + 34
15 llvm-tblgen              0x0000000103595b2e std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, void*>*) + 46
16 llvm-tblgen              0x0000000103595b2e std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, void*>*) + 46
17 llvm-tblgen              0x0000000103595b22 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, void*>*) + 34
18 llvm-tblgen              0x0000000103595b22 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, void*>*) + 34
19 llvm-tblgen              0x0000000103595b2e std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, void*>*) + 46
20 llvm-tblgen              0x0000000103595b2e std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>>>::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::unique_ptr<llvm::MultiClass, std::__1::default_delete<llvm::MultiClass>>>, void*>*) + 46
21 llvm-tblgen              0x00000001035958d4 llvm::TGParser::~TGParser() + 276
22 llvm-tblgen              0x0000000103594fbd llvm::TableGenMain(char const*, std::__1::function<bool (llvm::raw_ostream&, llvm::RecordKeeper const&)>) + 2557
23 llvm-tblgen              0x00000001032e1e94 tblgen_main(int, char**) + 148
24 dyld                     0x00007ff8122bc418 start + 1896
/bin/sh: line 1: 29272 Abort trap: 6           /Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build/bin/llvm-tblgen -gen-asm-matcher -I /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target/RISCV -I/Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build/include -I/Users/runner/work/rust/rust/src/llvm-project/llvm/include -I /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target -no-warn-on-unused-template-args /Users/runner/work/rust/rust/src/llvm-project/llvm/lib/Target/RISCV/RISCV.td --write-if-changed -o lib/Target/RISCV/RISCVGenAsmMatcher.inc -d lib/Target/RISCV/RISCVGenAsmMatcher.inc.d
[1686/3708] Building RISCVGenCompressInstEmitter.inc...
[1687/3708] Building RISCVGenAsmWriter.inc...
[1688/3708] Building RISCVGenDAGISel.inc...
ninja: build stopped: subcommand failed.

@bors
Copy link
Collaborator

bors commented May 12, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 12, 2025
@jieyouxu
Copy link
Member

jieyouxu commented May 12, 2025

That is

llvm-tblgen Segmentation fault in CI on dist-aarch64-apple #109624

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2025
@bors
Copy link
Collaborator

bors commented May 12, 2025

⌛ Testing commit 2fdf3d9 with merge 420ca71...

@bors
Copy link
Collaborator

bors commented May 12, 2025

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 420ca71 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 12, 2025
@bors bors merged commit 420ca71 into rust-lang:master May 12, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 12, 2025
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing bc7512e (parent) -> 420ca71 (this PR)

Test differences

Show 33150 test diffs

Stage 1

  • c_str2::cstr_from_bytes_until_nul: pass -> [missing] (J0)
  • collections::btree::map::tests::test_extract_if::height_0_keeping_one: pass -> [missing] (J0)
  • collections::hash::set::tests::test_retain: pass -> [missing] (J0)
  • collections::vec_deque::tests::test_shrink_to_fit: pass -> [missing] (J0)
  • f128::test_to_degrees: pass -> [missing] (J0)
  • ffi::os_str::tests::test_os_string_reserve_exact: pass -> [missing] (J0)
  • fmt::builders::debug_map::test_single: pass -> [missing] (J0)
  • fmt::builders::debug_struct::test_nested: pass -> [missing] (J0)
  • iter::adapters::intersperse::test_fold_specialization_intersperse: pass -> [missing] (J0)
  • iter::adapters::peekable::test_iterator_peekable: pass -> [missing] (J0)
  • iter::adapters::skip_while::test_iterator_skip_while_fold: pass -> [missing] (J0)
  • iter::traits::iterator::test_iterator_rev_advance_back_by: pass -> [missing] (J0)
  • num::i32::test_carrying_mul_add: pass -> [missing] (J0)
  • num::i64::test_midpoint: pass -> [missing] (J0)
  • num::i64::test_pow: pass -> [missing] (J0)
  • num::u128::test_rotate: pass -> [missing] (J0)
  • rc::test_downcast: pass -> [missing] (J0)
  • slice::test_vec_default: pass -> [missing] (J0)
  • sync::drop_arc_weak: pass -> [missing] (J0)
  • vec::test_move_items_zero_sized: pass -> [missing] (J0)
  • vec::test_swap_remove_empty: pass -> [missing] (J0)
  • vec_deque::test_param_int: pass -> [missing] (J0)
  • bit_set::tests::bitset_clone_from: pass -> [missing] (J1)
  • config::externs::tests::test_split_extern_opt_nested_invalid: pass -> [missing] (J1)
  • errors::verify_ast_passes_forbidden_default_8: pass -> [missing] (J1)
  • errors::verify_lint_unknown_tool_in_scoped_lint_0: pass -> [missing] (J1)
  • errors::verify_parse_async_move_block_in_2015_70: pass -> [missing] (J1)
  • errors::verify_parse_incorrect_visibility_restriction_45: pass -> [missing] (J1)
  • errors::verify_passes_no_patterns_132: pass -> [missing] (J1)
  • errors::verify_privacy_unnameable_types_lint_5: pass -> [missing] (J1)
  • json::tests::empty: pass -> [missing] (J1)
  • lints::verify_lint_builtin_trivial_bounds_32: pass -> [missing] (J1)
  • parser::tests::single_label_with_message: pass -> [missing] (J1)
  • session_diagnostics::verify_borrowck_tail_expr_drop_order_8: pass -> [missing] (J1)
  • spec::tests::xtensa_esp32_none_elf: pass -> [missing] (J1)
  • btree::map::first_and_last_0_nightly: pass -> [missing] (J2)
  • btree::set::clone_10k_and_drain_all: pass -> [missing] (J2)
  • hash::sip::bench_bytes_c_128: pass -> [missing] (J2)
  • sort::tests::unstable::correct_u128_random: pass -> [missing] (J2)
  • sort::tests::unstable::self_cmp_cell_i32_random_d20: pass -> [missing] (J2)
  • str::to_lowercase::long_lorem_ipsum: pass -> [missing] (J2)
  • vec::bench_clone_from_01_0000_0010: pass -> [missing] (J2)
  • vec::bench_dedup_none_100: pass -> [missing] (J2)
  • vec::bench_extend_from_slice_0010_0010: pass -> [missing] (J2)
  • sort::tests::stable::self_cmp_cell_i32_random_d20: ignore -> [missing] (J3)
  • sort::tests::unstable::correct_cell_i32_random_d2: ignore -> [missing] (J3)
  • sort::tests::unstable::stability_cell_i32_random: ignore -> [missing] (J3)

Stage 2

  • any::any_downcast_mut: [missing] -> pass (J0)
  • c_str2::into_rc: [missing] -> pass (J0)
  • fmt::builders::debug_set::test_nested_non_exhaustive: [missing] -> pass (J0)
  • iter::adapters::filter_map::test_filter_map_fold: [missing] -> pass (J0)
  • iter::traits::step::test_step_backward: [missing] -> pass (J0)
  • mpsc::oneshot_multi_thread_send_recv_stress: [missing] -> pass (J0)
  • net::socket_addr::socket_v6_to_str: [missing] -> pass (J0)
  • num::i32::test_midpoint: [missing] -> pass (J0)
  • num::i8::test_num: [missing] -> pass (J0)
  • num::i8::test_signum: [missing] -> pass (J0)
  • num::u16::test_le: [missing] -> pass (J0)
  • once_lock::sync_once_cell: [missing] -> pass (J0)
  • slice::subslice_patterns: [missing] -> pass (J0)
  • str::slice_index::boundary::rangeinclusive_1::pass: [missing] -> pass (J0)
  • str::test_split_char_iterator_no_trailing: [missing] -> pass (J0)
  • str::test_starts_with: [missing] -> pass (J0)
  • sync::into_inner: [missing] -> pass (J0)
  • test_iter_debug: [missing] -> pass (J0)
  • vec::partialeq_vec_and_prim: [missing] -> pass (J0)
  • vec::test_zst_capacity: [missing] -> pass (J0)
  • clean::types::tests::should_not_trim: [missing] -> pass (J1)
  • coverage::tests::test_covgraph_switchint_then_loop_else_return: [missing] -> pass (J1)
  • errors::autodiff::verify_builtin_macros_autodiff_34: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_accessible_multiple_paths_13: [missing] -> pass (J1)
  • errors::verify_expand_must_repeat_once_1: [missing] -> pass (J1)
  • errors::verify_metadata_required_panic_strategy_5: [missing] -> pass (J1)
  • errors::verify_parse_missing_const_type_88: [missing] -> pass (J1)
  • errors::verify_passes_continue_labeled_block_127: [missing] -> pass (J1)
  • errors::verify_passes_doc_test_literal_41: [missing] -> pass (J1)
  • errors::verify_passes_link_name_60: [missing] -> pass (J1)
  • errors::verify_resolve_imported_macro_not_found_39: [missing] -> pass (J1)
  • errors::verify_session_invalid_float_literal_suffix_37: [missing] -> pass (J1)
  • html::url_parts_builder::tests::collect: [missing] -> pass (J1)
  • lints::verify_lint_builtin_decl_unsafe_method_20: [missing] -> pass (J1)
  • tests::test_valid_shebang: [missing] -> pass (J1)
  • ascii::is_ascii::unaligned_head_long::case02_align_to: [missing] -> pass (J2)
  • hash::sip::bench_str_over_8_bytes: [missing] -> pass (J2)
  • num::flt2dec::strategy::dragon::bench_big_exact_inf: [missing] -> pass (J2)
  • slice::sort_unstable_large_expensive: [missing] -> pass (J2)
  • slice::swap_with_slice_4x_usize_3000: [missing] -> pass (J2)
  • sort::tests::stable::stability_i32_random: [missing] -> pass (J2)
  • str::char_count::emoji_medium::case01_filter_count_cont_bytes: [missing] -> pass (J2)
  • str::char_count::ru_medium::case00_libcore: [missing] -> pass (J2)
  • str::char_count::zh_tiny::case00_libcore: [missing] -> pass (J2)
  • str::find_zzz_char::short_mixed: [missing] -> pass (J2)
  • string::test_try_reserve: [missing] -> pass (J2)
  • term::terminfo::parm::tests::test_op_i: [missing] -> pass (J2)
  • tests::shuffle_tests: [missing] -> pass (J2)
  • vec::bench_in_place_u128_0010_i0: [missing] -> pass (J2)
  • sort::tests::stable::deterministic_cell_i32_ascending: [missing] -> ignore (J3)
  • sort::tests::unstable::panic_observable_is_less_descending: [missing] -> ignore (J3)
  • sort::tests::unstable::self_cmp_i32_random_s95: [missing] -> ignore (J3)
  • os::net::linux_ext::tests::deferaccept: [missing] -> pass (J4)

(and 16504 additional test diffs)

Additionally, 16546 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 420ca7104f4db107837cba4d8e48a82c53fcb76c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 5201.0s -> 1579.4s (-69.6%)
  2. test-various: 4216.3s -> 2420.2s (-42.6%)
  3. x86_64-gnu-aux: 6071.1s -> 4351.2s (-28.3%)
  4. aarch64-apple: 4552.3s -> 3331.8s (-26.8%)
  5. x86_64-apple-1: 6105.6s -> 6843.3s (12.1%)
  6. dist-apple-various: 6509.1s -> 7247.7s (11.3%)
  7. dist-arm-linux: 4688.0s -> 5154.9s (10.0%)
  8. x86_64-msvc-2: 7253.3s -> 6667.1s (-8.1%)
  9. mingw-check: 1265.0s -> 1342.3s (6.1%)
  10. dist-android: 2510.6s -> 2656.4s (5.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (420ca71): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.173s -> 771.187s (-0.26%)
Artifact size: 365.41 MiB -> 365.44 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-async_drop `#![feature(async_drop)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
7 participants