Flush errors before deep normalize in dropck_outlives
#140947
+132
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
S-waiting-on-review
|
r? lcnr |
|
@bors r+ rollup |
|
@bors r- |
bors
added
S-waiting-on-author
lcnr
reviewed
May 12, 2025
| if !errors.is_empty() { | ||
| return Err(errors); | ||
| } | ||
|
|
||
| ocx.deeply_normalize(&cause, param_env, ty)?; | ||
|
|
||
| let errors = ocx.select_where_possible(); |
There was a problem hiding this comment.
are these errors always empty now?
There was a problem hiding this comment.
reworked this code a bit b/c it was kinda goofy, returning Err(vec![]) in case deep normalization succeeded.
compiler-errors
force-pushed
the
pending-norm
branch
from
e2b4654 to
8bf387d
Compare
lcnr
reviewed
May 13, 2025
| let errors = ocx.select_where_possible(); | ||
| debug!("normalize errors: {ty} ~> {errors:#?}"); | ||
| return Err(errors); | ||
| match ocx.deeply_normalize(&cause, param_env, ty) { |
There was a problem hiding this comment.
pls add comment that we do this match to get FulfillmentErrors to report in case query_normalize failed to avoid ICE due to a delayed bug
compiler-errors
force-pushed
the
pending-norm
branch
from
8bf387d to
a508011
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deep normalization doesn't allow the ocx to have pending obligations, so process them before deeply normalizing.
Fixes #140931
Fixes #140462