-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Allow initializing logger with additional tracing Layer #140969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Stypox
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
Stypox:logger-layer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't understand why the build fails, locally it works. The CI logs are 400MB, but here are the last few lines:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functions to the
rustc_log
andrustc_driver_impl
crates to allow initializing the logger with an additionaltracing_subscriber::Layer
. This will be used in Miri to save trace events to file using e.g.tracing-chrome
's ortracing-tracy
'sLayer
s.Additional context on the choice of signature can be found in this Zulip thread.
I re-exported
tracing_subscriber::{Layer, Registry};
fromrustc_log
so thatrustc_driver_impl
can use them in the function signature without depending ontracing_subscriber
directly. I did this to avoid copy-pasting the dependency line with all of the enabled features from therustc_log
to therustc_driver_impl
's Cargo.toml, which would have possibly led to redundancies and inconsistencies.r? @RalfJung