Add TRACING_ENABLED to Machine and add enter_trace_span!() #140972
+25
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary infrastructure to make it possible to do tracing calls from within
rustc_const_eval
when running Miri, while making sure they don't impact the performance of normal compiler execution. This is done by adding aconst
boolean toMachine
, false by default, but that will be set to true in Miri only. The tracing macroenter_trace_span!()
checks if it is true before doing anything, and since the value of aconst
is known at compile time, if it it false it the whole tracing call should be optimized out.I will soon open further PRs to add tracing macro calls similar to this one, so that afterwards it will be possible to learn more about Miri's time spent in the various interpretation steps:
r? @RalfJung