-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Disable tests/run-make/mte-ffi
because no CI runners have MTE extensions enabled
#142300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jieyouxu
wants to merge
2
commits into
rust-lang:master
Choose a base branch
from
jieyouxu:exp-partial-revert-141576
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
rust-bors bot
added a commit
that referenced
this pull request
Jun 10, 2025
[EXPERIMENTAL] Revert `mte-ffi` changes See #141600. try-job: aarch64-gnu try-job: aarch64-gnu-llvm-19-1
This comment was marked as off-topic.
This comment was marked as off-topic.
@bors2 try |
rust-bors bot
added a commit
that referenced
this pull request
Jun 10, 2025
[EXPERIMENTAL] Revert `mte-ffi` changes See #141600. try-job: aarch64-gnu
This comment has been minimized.
This comment has been minimized.
e22aa15
to
3e712e5
Compare
mte-ffi
changesmte-ffi
changes
mte-ffi
changesmte-ffi
changes
3e712e5
to
45682df
Compare
This comment has been minimized.
This comment has been minimized.
4ce5f14
to
1f9346c
Compare
@bors2 try jobs=aarch64-gnu |
rust-bors bot
added a commit
that referenced
this pull request
Jul 6, 2025
[EXPERIMENTAL] Revert `mte-ffi` changes Based on > > it failed on aarch64 (on the new aarch64-gnu-llvm-19-1 job introduced in this PR) > > This feature requires ARMv8.5 or higher. And it has to be enabled. Maybe the CI job runner does not support this extension? Let's revert the changes to this test in #141576. However, I can't explain why the test manages to *pass* on `aarch64-gnu` but not `aarch64-gnu-llvm-1` #141600. ### References - https://www.kernel.org/doc/html/v5.10/arm64/memory-tagging-extension.html try-job: aarch64-gnu
This comment has been minimized.
This comment has been minimized.
💔 Test failed
|
1f9346c
to
c6cc140
Compare
@bors2 try jobs=aarch64-gnu |
rust-bors bot
added a commit
that referenced
this pull request
Jul 7, 2025
[EXPERIMENTAL] Revert `mte-ffi` changes Based on > > it failed on aarch64 (on the new aarch64-gnu-llvm-19-1 job introduced in this PR) > > This feature requires ARMv8.5 or higher. And it has to be enabled. Maybe the CI job runner does not support this extension? Let's revert the changes to this test in #141576. However, I can't explain why the test manages to *pass* on `aarch64-gnu` but not `aarch64-gnu-llvm-1` #141600. ### References - https://www.kernel.org/doc/html/v5.10/arm64/memory-tagging-extension.html try-job: aarch64-gnu
This comment has been minimized.
This comment has been minimized.
💔 Test failed
|
aarch64-gnu-llvm-19-1
|
aarch64-gnu
|
mte-ffi
changestests/run-make/mte-ffi
because no CI runners have MTE extensions enabled
Partially reverts commit 40311c4.
See RUST-141600: this test is broken in two ways: 1. This test triggers `-Wincompatible-pointer-types` on GCC 14. 2. This test requires ARMv8.5+ w/ MTE extensions enabled, but GHA CI runner hardware do not have this enabled.
c6cc140
to
37136dd
Compare
rustbot has assigned @Mark-Simulacrum. Use |
(Mark has a ton of assigned PRs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-run-make
Area: port run-make Makefiles to rmake.rs
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the
tests/run-make/mte-ffi
run-make test because it is (1) broken, and (2) no CI runners have suitable MTE extensions enabled to run it correctly. This test being broken is tracked by #141600.The first commit also reverts
mte-ffi
changes introduced in #141576, as those fixes potentially changes the meaning of the test.cc @dheaton-arm (as this test was introduced in #128384)
Context
In #141576 when converting PR CI runners from x86_64 to aarch64 runners, it was noticed that this test failed on
aarch64-gnu-llvm-19-1
but notaarch64-gnu
. It turns out that:aarch64-gnu-llvm-19-1
gcc version 14.2.0 (Ubuntu 14.2.0-4ubuntu2)
lscpu
output, the hardware that was used for this runner does not have MTE enabled.aarch64-gnu
gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04)
lscpu
output, the hardware that was used for this runner does not have MTE enabled.Based on this comment, it seems like the test requires hardware with MTE extensions enabled to run properly (on ARMv8.5 or higher).
Furthermore, I believe this test does indeed have mismatched pointer type issues, i.e.
Which is only exposed by
aarch64-gnu-llvm-19-1
becauseaarch64-gnu-llvm-19-1
uses gcc 14.2.0 whereasaarch64-gnu
uses gcc 11.14.0.Details
aarch64-gnu-llvm-19-1
aarch64-gnu
References
cc @marcoieni as this PR reverts the
tests/run-make/mte-ffi
changes from #141576.